D/ldc
1
0
Fork 0
mirror of https://github.com/xomboverlord/ldc.git synced 2026-02-28 01:23:14 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Make == for associative arrays test for equality, not identity.

Browse Source 
_aaEq was added to runtime/internal/aaA.d which forwards to
TypeInfo_AssociativeArray.equals in genobj.d. On the codegen side, DtoAAEquals
was added to gen/aa.cpp and is called from EqualExp::toElem in gen/toir.cpp.

I assume that the frontend will produce an error if == is used on associative
arrays of different type.

This fixes DMD bug 1429.
This commit is contained in:
Christian Kamm
2009-06-21 19:05:24 +02:00
parent 62dee01d35
commit 265cbea170
7 changed files with 120 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
gen/toir.cpp
View File

@@ -1448,7 +1448,7 @@ DValue* EqualExp::toElem(IRState* p)
// the Tclass catches interface comparisons, regular
// class equality should be rewritten as a.opEquals(b) by this time
if (t->isintegral() || t->ty == Tpointer || t->ty == Tclass || t->ty == Taarray)
if (t->isintegral() || t->ty == Tpointer || t->ty == Tclass)
{
Logger::println("integral or pointer or interface");
llvm::ICmpInst::Predicate cmpop;
@@ -1482,6 +1482,11 @@ DValue* EqualExp::toElem(IRState* p)
Logger::println("static or dynamic array");
eval = DtoArrayEquals(loc,op,l,r);
}
else if (t->ty == Taarray)
{
Logger::println("associative array");
eval = DtoAAEquals(loc,op,l,r);
}
else if (t->ty == Tdelegate)
{
Logger::println("delegate");