From 6e427fe81811d883d48878d32cf1ce46617af260 Mon Sep 17 00:00:00 2001 From: kai Date: Fri, 3 Aug 2012 06:36:35 +0200 Subject: [PATCH] Prefer C++-style casts. This is based on Item 2 of "More Effective C++". In general, the C++ cast operators are more expressive and easy to find, e.g. by grep. Using const_cast also shuts up some compiler warnings. --- gen/asm-x86-32.h | 4 ++-- gen/asm-x86-64.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/gen/asm-x86-32.h b/gen/asm-x86-32.h index 77a83e5d..7ae8ccba 100644 --- a/gen/asm-x86-32.h +++ b/gen/asm-x86-32.h @@ -2095,7 +2095,7 @@ namespace AsmParserx8632 Logger::cout() << "segmentPrefix: " << operand->segmentPrefix << '\n'; Logger::cout() << "constDisplacement: " << operand->constDisplacement << '\n'; for (unsigned i = 0; i < operand->symbolDisplacement.dim; i++) { - Expression* expr = (Expression*) operand->symbolDisplacement.data[i]; + Expression* expr = static_cast(operand->symbolDisplacement.data[i]); Logger::cout() << "symbolDisplacement[" << i << "] = " << expr->toChars() << '\n'; } } @@ -2967,7 +2967,7 @@ namespace AsmParserx8632 /* machine_mode mode; - insnTemplate->writestring((char*) directives[op - Op_db]); + insnTemplate->writestring(static_cast(directives[op - Op_db])); insnTemplate->writebyte(' '); do { diff --git a/gen/asm-x86-64.h b/gen/asm-x86-64.h index 89bcbeb3..044cba81 100644 --- a/gen/asm-x86-64.h +++ b/gen/asm-x86-64.h @@ -2231,7 +2231,7 @@ namespace AsmParserx8664 Logger::cout() << "segmentPrefix: " << operand->segmentPrefix << '\n'; Logger::cout() << "constDisplacement: " << operand->constDisplacement << '\n'; for (unsigned i = 0; i < operand->symbolDisplacement.dim; i++) { - Expression* expr = (Expression*) operand->symbolDisplacement.data[i]; + Expression* expr = static_cast(operand->symbolDisplacement.data[i]); Logger::cout() << "symbolDisplacement[" << i << "] = " << expr->toChars() << '\n'; } } @@ -3104,7 +3104,7 @@ namespace AsmParserx8664 /* machine_mode mode; - insnTemplate->writestring((char*) directives[op - Op_db]); + insnTemplate->writestring(static_cast(directives[op - Op_db])); insnTemplate->writebyte(' '); do {