diff --git a/dmd/declaration.h b/dmd/declaration.h index 32103da2..4a728b96 100644 --- a/dmd/declaration.h +++ b/dmd/declaration.h @@ -636,7 +636,12 @@ struct FuncDeclaration : Declaration FuncDeclaration *isFuncDeclaration() { return this; } // llvmdc stuff + + // vars declared in this function that nested funcs reference + // is this is not empty, nestedFrameRef is set and these VarDecls + // probably have nestedref set too, see VarDeclaration::checkNestedReference std::set nestedVars; + std::string intrinsicName; bool isIntrinsic(); diff --git a/dmd/expression.c b/dmd/expression.c index da6a0af0..808eff3b 100644 --- a/dmd/expression.c +++ b/dmd/expression.c @@ -3370,6 +3370,7 @@ Lagain: */ Dsymbol *s = cd->toParent2(); ClassDeclaration *cdn = s->isClassDeclaration(); + FuncDeclaration *fdn = s->isFuncDeclaration(); //printf("cd isNested, cdn = %s\n", cdn ? cdn->toChars() : "null"); if (cdn) @@ -3421,6 +3422,22 @@ Lagain: } else if (thisexp) error("e.new is only for allocating nested classes"); + else if (fdn) + { + // make sure the parent context fdn of cd is reachable from sc + for (Dsymbol *sp = sc->parent; 1; sp = sp->parent) + { + if (fdn == sp) + break; + FuncDeclaration *fsp = sp ? sp->isFuncDeclaration() : NULL; + if (!sp || (fsp && fsp->isStatic())) + { + error("outer function context of %s is needed to 'new' nested class %s", fdn->toPrettyChars(), cd->toPrettyChars()); + break; + } + } + + } } else if (thisexp) error("e.new is only for allocating nested classes"); diff --git a/gen/classes.cpp b/gen/classes.cpp index f02b6c5d..9c0376ff 100644 --- a/gen/classes.cpp +++ b/gen/classes.cpp @@ -842,12 +842,6 @@ DValue* DtoNewClass(Loc loc, TypeClass* tc, NewExp* newexp) Logger::println("Resolving nested context"); LOG_SCOPE; - if (gIR->func()->decl->isStatic()) - { - newexp->error("function %s is static and cannot access nested class %s", gIR->func()->decl->toPrettyChars(), tc->sym->toPrettyChars()); - fatal(); - } - // get context LLValue* nest = DtoNestedContext(loc, tc->sym); diff --git a/gen/llvmhelpers.cpp b/gen/llvmhelpers.cpp index e11272cf..fa3f73fc 100644 --- a/gen/llvmhelpers.cpp +++ b/gen/llvmhelpers.cpp @@ -390,11 +390,15 @@ LLValue* DtoNestedContext(Loc loc, Dsymbol* sym) LOG_SCOPE; IrFunction* irfunc = gIR->func(); - + + // if this func has its own vars that are accessed by nested funcs + // use its own context if (irfunc->nestedVar) return irfunc->nestedVar; + // otherwise, it may have gotten a context from the caller else if (irfunc->nestArg) return irfunc->nestArg; + // or just have a this argument else if (irfunc->thisArg) { ClassDeclaration* cd = irfunc->decl->isMember2()->isClassDeclaration();