Minix/minix
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

panic() cleanup.

Browse Source 
this change
   - makes panic() variadic, doing full printf() formatting -
     no more NO_NUM, and no more separate printf() statements
     needed to print extra info (or something in hex) before panicing
   - unifies panic() - same panic() name and usage for everyone -
     vm, kernel and rest have different names/syntax currently
     in order to implement their own luxuries, but no longer
   - throws out the 1st argument, to make source less noisy.
     the panic() in syslib retrieves the server name from the kernel
     so it should be clear enough who is panicing; e.g.
         panic("sigaction failed: %d", errno);
     looks like:
         at_wini(73130): panic: sigaction failed: 0
         syslib:panic.c: stacktrace: 0x74dc 0x2025 0x100a
   - throws out report() - printf() is more convenient and powerful
   - harmonizes/fixes the use of panic() - there were a few places
     that used printf-style formatting (didn't work) and newlines
     (messes up the formatting) in panic()
   - throws out a few per-server panic() functions
   - cleans up a tie-in of tty with panic()

merging printf() and panic() statements to be done incrementally.
This commit is contained in:
Ben Gras
2010-03-05 15:05:11 +00:00
parent 851dc95566
commit 35a108b911
171 changed files with 1381 additions and 1649 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/log/diag.c
View File

@@ -40,9 +40,6 @@ endpoint_t from; /* who sent this message? */
CPF_WRITE);
if (gid == -1)
{
#if 0
report("LOG","cpf_grant_direct failed for TTY", errno);
#endif
return EDONTREPLY;
}
@@ -55,7 +52,7 @@ endpoint_t from; /* who sent this message? */
if (r == OK) r= mess.m_type;
if (r != OK)
{
report("LOG","couldn't get copy of kmessages from TTY", r);
printf("log: couldn't get copy of kmessages from TTY: %d\n", r);
return EDONTREPLY;
}
}
@@ -63,7 +60,7 @@ endpoint_t from; /* who sent this message? */
{
/* Try to get a fresh copy of the buffer with kernel messages. */
if ((r=sys_getkmessages(&kmess)) != OK) {
report("LOG","couldn't get copy of kmessages", r);
printf("log: couldn't get copy of kmessages: %d\n", r);
return EDONTREPLY;
}
prev_nextp= &kernel_prev_next;