panic() cleanup.
this change
- makes panic() variadic, doing full printf() formatting -
no more NO_NUM, and no more separate printf() statements
needed to print extra info (or something in hex) before panicing
- unifies panic() - same panic() name and usage for everyone -
vm, kernel and rest have different names/syntax currently
in order to implement their own luxuries, but no longer
- throws out the 1st argument, to make source less noisy.
the panic() in syslib retrieves the server name from the kernel
so it should be clear enough who is panicing; e.g.
panic("sigaction failed: %d", errno);
looks like:
at_wini(73130): panic: sigaction failed: 0
syslib:panic.c: stacktrace: 0x74dc 0x2025 0x100a
- throws out report() - printf() is more convenient and powerful
- harmonizes/fixes the use of panic() - there were a few places
that used printf-style formatting (didn't work) and newlines
(messes up the formatting) in panic()
- throws out a few per-server panic() functions
- cleans up a tie-in of tty with panic()
merging printf() and panic() statements to be done incrementally.
This commit is contained in:
@@ -102,7 +102,7 @@ PRIVATE int sef_cb_init_fresh(int type, sef_init_info_t *info)
|
||||
|
||||
/* Retrieve first randomness buffer with parameters. */
|
||||
if (OK != (s=sys_getrandomness(&krandom))) {
|
||||
report("RANDOM", "sys_getrandomness failed", s);
|
||||
printf("RANDOM: sys_getrandomness failed: %d\n", s);
|
||||
exit(1);
|
||||
}
|
||||
|
||||
@@ -317,7 +317,7 @@ message *m_ptr; /* pointer to alarm message */
|
||||
|
||||
/* Schedule new alarm for next m_random call. */
|
||||
if (OK != (s=sys_setalarm(KRANDOM_PERIOD, 0)))
|
||||
report("RANDOM", "sys_setalarm failed", s);
|
||||
printf("RANDOM: sys_setalarm failed: %d\n", s);
|
||||
}
|
||||
|
||||
/*============================================================================*
|
||||
|
||||
@@ -73,7 +73,7 @@ int count;
|
||||
printf("random_update: got %d samples for source %d\n", count, source);
|
||||
#endif
|
||||
if (source < 0 || source >= TOTAL_SOURCES)
|
||||
panic("memory", "random_update: bad source", source);
|
||||
panic("random_update: bad source: %d", source);
|
||||
for (i= 0; i<count; i++)
|
||||
add_sample(source, buf[i]);
|
||||
reseed();
|
||||
|
||||
Reference in New Issue
Block a user