Minix/minix
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

panic() cleanup.

Browse Source 
this change
   - makes panic() variadic, doing full printf() formatting -
     no more NO_NUM, and no more separate printf() statements
     needed to print extra info (or something in hex) before panicing
   - unifies panic() - same panic() name and usage for everyone -
     vm, kernel and rest have different names/syntax currently
     in order to implement their own luxuries, but no longer
   - throws out the 1st argument, to make source less noisy.
     the panic() in syslib retrieves the server name from the kernel
     so it should be clear enough who is panicing; e.g.
         panic("sigaction failed: %d", errno);
     looks like:
         at_wini(73130): panic: sigaction failed: 0
         syslib:panic.c: stacktrace: 0x74dc 0x2025 0x100a
   - throws out report() - printf() is more convenient and powerful
   - harmonizes/fixes the use of panic() - there were a few places
     that used printf-style formatting (didn't work) and newlines
     (messes up the formatting) in panic()
   - throws out a few per-server panic() functions
   - cleans up a tie-in of tty with panic()

merging printf() and panic() statements to be done incrementally.
This commit is contained in:
Ben Gras
2010-03-05 15:05:11 +00:00
parent 851dc95566
commit 35a108b911
171 changed files with 1381 additions and 1649 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
kernel/system.c
View File

@@ -324,7 +324,7 @@ PUBLIC void send_sig(int proc_nr, int sig_nr)
register struct proc *rp;
if(!isokprocn(proc_nr) || isemptyn(proc_nr))
minix_panic("send_sig to empty process", proc_nr);
panic("send_sig to empty process: %d", proc_nr);
rp = proc_addr(proc_nr);
sigaddset(&priv(rp)->s_sig_pending, sig_nr);
@@ -354,7 +354,7 @@ int sig_nr; /* signal to be sent */
register struct proc *rp;
if (proc_nr == PM_PROC_NR)
minix_panic("cause_sig: PM gets signal", NO_NUM);
panic("cause_sig: PM gets signal");
/* Check if the signal is already pending. Process it otherwise. */
rp = proc_addr(proc_nr);
@@ -458,7 +458,7 @@ register struct proc *rc; /* slot of process to clean up */
register struct proc *rp; /* iterate over process table */
register struct proc **xpp; /* iterate over caller queue */
if(isemptyp(rc)) minix_panic("clear_proc: empty process", rc->p_endpoint);
if(isemptyp(rc)) panic("clear_proc: empty process: %d", rc->p_endpoint);
if(rc->p_endpoint == PM_PROC_NR || rc->p_endpoint == VFS_PROC_NR ||
rc->p_endpoint == VM_PROC_NR)
@@ -468,7 +468,7 @@ register struct proc *rc; /* slot of process to clean up */
*/
printf("died: ");
proc_stacktrace(rc);
minix_panic("system process died", rc->p_endpoint);
panic("system process died: %d", rc->p_endpoint);
}
/* Make sure that the exiting process is no longer scheduled. */