panic() cleanup.
this change
- makes panic() variadic, doing full printf() formatting -
no more NO_NUM, and no more separate printf() statements
needed to print extra info (or something in hex) before panicing
- unifies panic() - same panic() name and usage for everyone -
vm, kernel and rest have different names/syntax currently
in order to implement their own luxuries, but no longer
- throws out the 1st argument, to make source less noisy.
the panic() in syslib retrieves the server name from the kernel
so it should be clear enough who is panicing; e.g.
panic("sigaction failed: %d", errno);
looks like:
at_wini(73130): panic: sigaction failed: 0
syslib:panic.c: stacktrace: 0x74dc 0x2025 0x100a
- throws out report() - printf() is more convenient and powerful
- harmonizes/fixes the use of panic() - there were a few places
that used printf-style formatting (didn't work) and newlines
(messes up the formatting) in panic()
- throws out a few per-server panic() functions
- cleans up a tie-in of tty with panic()
merging printf() and panic() statements to be done incrementally.
This commit is contained in:
+3
-3
@@ -22,7 +22,7 @@ void util_timer_start(util_timingdata_t *timingdata, char *name)
|
||||
}
|
||||
|
||||
if (timingdata->starttimes[HIGHCOUNT]) {
|
||||
panic(__FILE__, "restart timer?", NO_NUM);
|
||||
panic("restart timer?");
|
||||
return;
|
||||
}
|
||||
|
||||
@@ -37,7 +37,7 @@ void util_timer_end(util_timingdata_t *timingdata)
|
||||
|
||||
read_tsc(&h, &l);
|
||||
if (!timingdata->starttimes[HIGHCOUNT]) {
|
||||
panic(__FILE__, "timer stopped but not started", NO_NUM);
|
||||
panic("timer stopped but not started");
|
||||
return;
|
||||
}
|
||||
if (timingdata->starttimes[HIGHCOUNT] == h) {
|
||||
@@ -73,7 +73,7 @@ void util_timer_end(util_timingdata_t *timingdata)
|
||||
timingdata->binsize;
|
||||
if (bin < 0 || bin >= TIMING_POINTS) {
|
||||
/* not serious, but can't happen, so shouldn't */
|
||||
panic(__FILE__, "bin out of range", bin);
|
||||
panic("bin out of range: %d", bin);
|
||||
} else {
|
||||
timingdata->lock_timings[bin]++;
|
||||
timingdata->measurements++;
|
||||
|
||||
Reference in New Issue
Block a user