Minix/minix
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

panic() cleanup.

Browse Source 
this change
   - makes panic() variadic, doing full printf() formatting -
     no more NO_NUM, and no more separate printf() statements
     needed to print extra info (or something in hex) before panicing
   - unifies panic() - same panic() name and usage for everyone -
     vm, kernel and rest have different names/syntax currently
     in order to implement their own luxuries, but no longer
   - throws out the 1st argument, to make source less noisy.
     the panic() in syslib retrieves the server name from the kernel
     so it should be clear enough who is panicing; e.g.
         panic("sigaction failed: %d", errno);
     looks like:
         at_wini(73130): panic: sigaction failed: 0
         syslib:panic.c: stacktrace: 0x74dc 0x2025 0x100a
   - throws out report() - printf() is more convenient and powerful
   - harmonizes/fixes the use of panic() - there were a few places
     that used printf-style formatting (didn't work) and newlines
     (messes up the formatting) in panic()
   - throws out a few per-server panic() functions
   - cleans up a tie-in of tty with panic()

merging printf() and panic() statements to be done incrementally.
This commit is contained in:
Ben Gras
2010-03-05 15:05:11 +00:00
parent 851dc95566
commit 35a108b911
171 changed files with 1381 additions and 1649 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
test/safecopy/inc.h
View File

@@ -33,12 +33,12 @@
#define FIFO_WAIT(fid) { \
int a; \
if(read(fid, &a, sizeof(a)) != sizeof(a)) \
panic(__FILE__, "FIFO_WAIT failed", NO_NUM); \
panic("FIFO_WAIT failed"); \
}
#define FIFO_NOTIFY(fid) { \
int a = 1; \
if(write(fid, &a, sizeof(a)) != sizeof(a)) \
panic(__FILE__, "FIFO_NOTIFY failed", NO_NUM); \
panic("FIFO_NOTIFY failed"); \
}
#define DEBUG 0

4
test/safemap/inc.h
View File

@@ -29,12 +29,12 @@
#define FIFO_WAIT(fid) { \
int a; \
if(read(fid, &a, sizeof(a)) != sizeof(a)) \
panic(__FILE__, "FIFO_WAIT failed", NO_NUM); \
panic( "FIFO_WAIT failed"); \
}
#define FIFO_NOTIFY(fid) { \
int a = 1; \
if(write(fid, &a, sizeof(a)) != sizeof(a)) \
panic(__FILE__, "FIFO_NOTIFY failed", NO_NUM); \
panic( "FIFO_NOTIFY failed"); \
}
#define CHECK_TEST(who, result, expected, test_name) { \

4
test/safeperf/inc.h
View File

@@ -29,12 +29,12 @@
#define FIFO_WAIT(fid) { \
int a; \
if(read(fid, &a, sizeof(a)) != sizeof(a)) \
panic(__FILE__, "FIFO_WAIT failed", NO_NUM); \
panic( "FIFO_WAIT failed"); \
}
#define FIFO_NOTIFY(fid) { \
int a = 1; \
if(write(fid, &a, sizeof(a)) != sizeof(a)) \
panic(__FILE__, "FIFO_NOTIFY failed", NO_NUM); \
panic( "FIFO_NOTIFY failed"); \
}
#define REPORT_TEST(who, test_name, diff) { \

2
test/safeperf/requestor.c
View File

@@ -19,7 +19,7 @@ void read_write_buff(char* buff, int size, int is_write)
char c;
if(size % CLICK_SIZE != 0) {
panic("REQUESTOR", "buff_size not page aligned", NO_NUM);
panic("buff_size not page aligned");
}
if(is_write) {
for(i=0;i<size;i+=CLICK_SIZE) buff[i] = 1;