$NetBSD: patch-pack.c,v 1.3 2015/03/08 14:59:12 taca Exp $ Fix for CVE-2014-4975 from revision #46806 in ruby_2_1 branch. --- pack.c.orig 2015-01-30 07:42:52.000000000 +0000 +++ pack.c @@ -1088,7 +1088,8 @@ static const char b64_table[] = static void encodes(VALUE str, const char *s, long len, int type, int tail_lf) { - char buff[4096]; + enum {buff_size = 4096, encoded_unit = 4}; + char buff[buff_size + 1]; /* +1 for tail_lf */ long i = 0; const char *trans = type == 'u' ? uu_table : b64_table; char padding; @@ -1101,7 +1102,7 @@ encodes(VALUE str, const char *s, long l padding = '='; } while (len >= 3) { - while (len >= 3 && sizeof(buff)-i >= 4) { + while (len >= 3 && buff_size-i >= encoded_unit) { buff[i++] = trans[077 & (*s >> 2)]; buff[i++] = trans[077 & (((*s << 4) & 060) | ((s[1] >> 4) & 017))]; buff[i++] = trans[077 & (((s[1] << 2) & 074) | ((s[2] >> 6) & 03))]; @@ -1109,7 +1110,7 @@ encodes(VALUE str, const char *s, long l s += 3; len -= 3; } - if (sizeof(buff)-i < 4) { + if (buff_size-i < encoded_unit) { rb_str_buf_cat(str, buff, i); i = 0; } @@ -1129,6 +1130,7 @@ encodes(VALUE str, const char *s, long l } if (tail_lf) buff[i++] = '\n'; rb_str_buf_cat(str, buff, i); + if ((size_t)i > sizeof(buff)) rb_bug("encodes() buffer overrun"); } static const char hex_table[] = "0123456789ABCDEF";