Cleaned up libposix mmap()

Now we have proper setting of errno and using pfn based mmap for both types of mmap calls.
This commit is contained in:
Bahadir Balban
2008-10-29 20:01:31 +02:00
parent 4046ad9e3f
commit 13b1b405a5
4 changed files with 60 additions and 29 deletions

View File

@@ -26,7 +26,7 @@ struct mmap_descriptor {
off_t offset;
};
void *mmap(void *start, size_t length, int prot, int flags, int fd, off_t offset)
static inline void *l4_mmap(void *start, size_t length, int prot, int flags, int fd, off_t pgoffset)
{
/* Not enough MRs for all arguments, therefore we fill in a structure */
struct mmap_descriptor desc = {
@@ -35,38 +35,69 @@ void *mmap(void *start, size_t length, int prot, int flags, int fd, off_t offset
.prot = prot,
.flags = flags,
.fd = fd,
.offset = offset,
.offset = pgoffset,
};
int err;
int ret;
write_mr(L4SYS_ARG0, (unsigned long)&desc);
/* Call pager with MMAP request. */
if ((errno = l4_sendrecv(PAGER_TID, PAGER_TID, L4_IPC_TAG_MMAP)) < 0) {
printf("%s: IPC Error: %d.\n", __FUNCTION__, errno);
/* Call pager with MMAP request. Check ipc error. */
if ((ret = l4_sendrecv(PAGER_TID, PAGER_TID, L4_IPC_TAG_MMAP)) < 0) {
printf("%s: IPC Error: %d.\n", __FUNCTION__, ret);
return PTR_ERR(ret);
}
if (IS_ERR(ret = l4_get_retval()))
printf("%s: MMAP Error: %d.\n", __FUNCTION__, ret);
return (void *)ret;
}
void *mmap2(void *start, size_t length, int prot, int flags, int fd, off_t pgoffset)
{
void *ret = l4_mmap(start, length, prot, flags, fd, pgoffset);
if (IS_ERR(ret)) {
errno = -(int)ret;
return MAP_FAILED;
}
return 0;
}
void *mmap(void *start, size_t length, int prot, int flags, int fd, off_t offset)
{
return mmap2(start, length, prot, flags, fd, __pfn(offset));
}
int l4_munmap(void *start, size_t length)
{
int err;
write_mr(L4SYS_ARG0, (unsigned long)start);
write_mr(L4SYS_ARG1, length);
/* Call pager with MMAP request. */
if ((err = l4_sendrecv(PAGER_TID, PAGER_TID, L4_IPC_TAG_MMAP)) < 0) {
printf("%s: IPC Error: %d.\n", __FUNCTION__, err);
return err;
}
/* Check if syscall itself was successful */
if ((errno = l4_get_retval()) < 0) {
printf("%s: MMAP Error: %d.\n", __FUNCTION__, errno);
return MAP_FAILED;
if ((err = l4_get_retval()) < 0) {
printf("%s: MUNMAP Error: %d.\n", __FUNCTION__, err);
return err;
}
return 0;
}
int munmap(void *start, size_t length)
{
write_mr(L4SYS_ARG0, (unsigned long)start);
write_mr(L4SYS_ARG1, length);
int ret = l4_munmap(start, length);
/* Call pager with MMAP request. */
if ((errno = l4_sendrecv(PAGER_TID, PAGER_TID, L4_IPC_TAG_MMAP)) < 0) {
printf("%s: IPC Error: %d.\n", __FUNCTION__, errno);
return -1;
}
/* Check if syscall itself was successful */
if ((errno = l4_get_retval()) < 0) {
printf("%s: MUNMAP Error: %d.\n", __FUNCTION__, errno);
/* If error, return positive error code */
if (ret < 0) {
errno = -ret;
return -1;
}
return 0;
@@ -93,6 +124,12 @@ int l4_msync(void *start, size_t length, int flags)
int msync(void *start, size_t length, int flags)
{
return l4_msync(start, length, flags);
int ret = l4_msync(start, length, flags);
if (ret < 0) {
errno = -ret;
return -1;
}
return 0;
}