sambuc/codezero
1
0
Fork 0
mirror of https://github.com/drasko/codezero.git synced 2026-03-02 10:33:15 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Removed the BUG() check on a legitimate l4_unmap return case

Browse Source 
When vmas are unmapped before being touched, l4_unmap may return a negative
value if the unmapped area was already faulted. This is normal behaviour
This commit is contained in:
Bahadir Balban
2009-05-12 18:24:31 +03:00
parent 33fcceb2b6
commit 44bf1db573
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tasks/mm0/src/munmap.c
View File

@@ -93,9 +93,13 @@ int vma_destroy_single(struct tcb *task, struct vm_area *vma)
if ((ret = vma_drop_merge_delete_all(vma)) < 0) if ((ret = vma_drop_merge_delete_all(vma)) < 0)
return ret; return ret;
/* Unmap the whole vma address range */ /*
BUG_ON(l4_unmap((void *)__pfn_to_addr(vma->pfn_start), * Unmap the whole vma address range. Note that this
vma->pfn_end - vma->pfn_start, task->tid) < 0); * may return -1 if the area was already faulted, which
* means the area was unmapped before being touched.
*/
l4_unmap((void *)__pfn_to_addr(vma->pfn_start),
vma->pfn_end - vma->pfn_start, task->tid);
/* Unlink and delete vma */ /* Unlink and delete vma */
list_del(&vma->list); list_del(&vma->list);