Various minor fixes.

Removed some commented out code.
Removed excessive printfs.
Fixed spid not initialising for mm0
Fixed some faults with fs0.

TODO:
- Need to store vfs files in a separate list.
- Need to define vnum as a vfs-file-specific data, i.e. in priv_data field of vm_file.
- Need to then fix vfs_receive_sys_open.

tasks/fs0/main.c

@@ -65,8 +65,10 @@ void handle_fs_requests(void)
 
 	/* Read mrs not used by syslib */
 	for (int i = 0; i < MR_UNUSED_TOTAL; i++)
-		mr[i] = read_mr(i);
+		mr[i] = read_mr(MR_UNUSED_START + i);
 
+	/* FIXME: Fix all these syscalls to read any buffer data from the caller task's utcb.
+	 * Make sure to return -EINVAL if data is not valid. */
 	switch(tag) {
 	case L4_IPC_TAG_WAIT:
 		printf("%s: Synced with waiting thread.\n", __TASKNAME__);

tasks/fs0/src/syscalls.c

@@ -91,7 +91,7 @@ int sys_open(l4id_t sender, const char *pathname, int flags, unsigned int mode)
 
 	/* Get the vnode */
 	if (IS_ERR(v = vfs_lookup_bypath(task, pathbuf))) {
-		if (!flags & O_CREAT) {
+		if (!(flags & O_CREAT)) {
 			return (int)v;
 		} else {
 			if ((err = vfs_create(task, pathname, mode)) < 0)
@@ -100,7 +100,7 @@ int sys_open(l4id_t sender, const char *pathname, int flags, unsigned int mode)
 	}
 
 	/* Get a new fd */
-	BUG_ON(!(fd = id_new(task->fdpool)));
+	BUG_ON((fd = id_new(task->fdpool)) < 0);
 
 	/* Assign the new fd with the vnode's number */
 	task->fd[fd] = v->vnum;

tasks/fs0/src/task.c

@@ -115,6 +115,7 @@ struct tcb *create_tcb(void)
 	if (!(t = kmalloc(sizeof(*t))))
 		return PTR_ERR(-ENOMEM);
 
+	t->fdpool = id_pool_new_init(TASK_OFILES_MAX);
 	INIT_LIST_HEAD(&t->list);
 	list_add_tail(&t->list, &tcb_head.list);
 	tcb_head.total++;