From 69ac6d67f0fa740adc4d3992e65d1cbc3b71db2a Mon Sep 17 00:00:00 2001 From: Bahadir Balban Date: Tue, 3 Nov 2009 16:04:43 +0200 Subject: [PATCH] Updated test example cml. Also update to various comments --- config/cml/examples/test/config.cml | 1 - src/generic/capability.c | 12 +++++------- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/config/cml/examples/test/config.cml b/config/cml/examples/test/config.cml index 5f1180d..83a7397 100644 --- a/config/cml/examples/test/config.cml +++ b/config/cml/examples/test/config.cml @@ -88,7 +88,6 @@ CONFIG_CONT0_OPT_NAME="caps" # CONFIG_CONT0_PAGER_LMA=0x40000 CONFIG_CONT0_PAGER_VMA=0x10000000 -CONFIG_CONT0_PAGER_SIZE=0x40000 # diff --git a/src/generic/capability.c b/src/generic/capability.c index 6d58fd4..b9189ab 100644 --- a/src/generic/capability.c +++ b/src/generic/capability.c @@ -99,9 +99,7 @@ struct capability *cap_list_find_by_rtype(struct cap_list *cap_list, * to free it to. * * In conclusion freeing of pool-type capabilities need to be done - * in order of privacy. -> It may get confusing as a space, thread - * group id or paged-thread group is not necessarily in a different - * privacy ring. + * in order of privacy. */ struct capability *capability_find_by_rtype(struct ktcb *task, unsigned int rtype) @@ -453,7 +451,7 @@ struct capability *cap_match_thread(struct capability *cap, if (action_flags == THREAD_CREATE) { /* - * FIXME: Add cid to task_ids arg. + * TODO: Add cid to task_ids arg. * * Its a thread create and we have no knowledge of * thread id, space id, or any other id. @@ -618,8 +616,8 @@ int cap_map_check(struct ktcb *target, unsigned long phys, unsigned long virt, /* * Limitation: We currently only check from sender's - * perspective. Sender always targets a real thread. - * Does sender have the right to do this ipc? + * perspective. This is because sender always targets a + * real thread. Does sender have the right to do this ipc? */ int cap_ipc_check(l4id_t to, l4id_t from, unsigned int flags, unsigned int ipc_type) @@ -716,7 +714,7 @@ int cap_thread_check(struct ktcb *task, { return 0; } -#endif +#endif /* End of !CONFIG_CAPABILITIES */ /* * FIXME: