sambuc/codezero
1
0
Fork 0
mirror of https://github.com/drasko/codezero.git synced 2026-07-21 06:35:23 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

Cleaner thread_create()

Browse Source
This commit is contained in:
Bahadir Balban
2009-05-26 16:48:36 +03:00
parent bece68fbf7
commit c25c81e95c
1 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/api/thread.c
View File

@@ -300,7 +300,7 @@ out:
int thread_create(struct task_ids *ids, unsigned int flags) int thread_create(struct task_ids *ids, unsigned int flags)
{ {
struct ktcb *new, *orig_task; struct ktcb *new, *orig_task = 0;
int err; int err;
flags &= THREAD_CREATE_MASK; flags &= THREAD_CREATE_MASK;
@@ -308,20 +308,23 @@ int thread_create(struct task_ids *ids, unsigned int flags)
if (!(new = tcb_alloc_init())) if (!(new = tcb_alloc_init()))
return -ENOMEM; return -ENOMEM;
if (flags != THREAD_NEW_SPACE) { if (flags == THREAD_SAME_SPACE || flags == THREAD_COPY_SPACE) {
BUG_ON(!(orig_task = tcb_find_by_space(ids->spid))); if (!(orig_task = tcb_find_by_space(ids->spid))) {
} else /* Pre-mature tcb needs freeing by free_page */
orig_task = 0; free_page(new);
return -EINVAL;
}
}
if ((err = thread_setup_space(new, ids, flags)) < 0) { if ((err = thread_setup_space(new, ids, flags)) < 0) {
/* Since it hasn't initialised maturely, we delete it this way */ /* Pre-mature tcb needs freeing by free_page */
free_page(new); free_page(new);
return err; return err;
} }
/* Set up ids and context using original tcb or from scratch */ /* Set up ids and context using original tcb or from scratch */
thread_setup_new_ids(ids, flags, new, (orig_task) ? orig_task : 0); thread_setup_new_ids(ids, flags, new, orig_task);
arch_setup_new_thread(new, (orig_task) ? orig_task : 0, flags); arch_setup_new_thread(new, orig_task, flags);
tcb_add(new); tcb_add(new);