From bbcbed61b0abb89cbc9c71fce36ebbe36fbf4146 Mon Sep 17 00:00:00 2001
From: Matt Jenkins <matt@majenko.co.uk>
Date: Sat, 19 Apr 2014 11:20:33 +0100
Subject: [PATCH 1/4] Resolved argument type mismatch warning

---
 tools/virtualmips/mips_memory.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/virtualmips/mips_memory.c b/tools/virtualmips/mips_memory.c
index f00a6de..1949049 100644
--- a/tools/virtualmips/mips_memory.c
+++ b/tools/virtualmips/mips_memory.c
@@ -173,7 +173,7 @@ void mips_mts32_show_stats (cpu_mips_t * cpu)
 #endif
 
     printf ("   Total lookups: %llu, misses: %llu, efficiency: %g%%\n",
-        cpu->mts_lookups, cpu->mts_misses,
+        (unsigned long long)cpu->mts_lookups, (unsigned long long)cpu->mts_misses,
         100 - ((double) (cpu->mts_misses * 100) / (double) cpu->mts_lookups));
 }
 

From 7205bb7ef2dd14f3f59fb89cca4d08081bdc39d9 Mon Sep 17 00:00:00 2001
From: Matt Jenkins <matt@majenko.co.uk>
Date: Sat, 19 Apr 2014 11:36:18 +0100
Subject: [PATCH 2/4] Switched from mktemp to mkstemp

---
 src/cmd/as/as.c | 7 ++++++-
 src/cmd/ld/ld.c | 8 +++++++-
 2 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/src/cmd/as/as.c b/src/cmd/as/as.c
index 08a5172..21bea9e 100644
--- a/src/cmd/as/as.c
+++ b/src/cmd/as/as.c
@@ -520,7 +520,12 @@ void startup ()
 {
     register int i;
 
-    mktemp (tfilename);
+    int fd = mkstemp (tfilename);
+    if (fd == -1) {
+        uerror ("cannot create temporary file %2", tfilename);
+    } else {
+        close(fd);
+    }
     for (i=STEXT; i<SBSS; i++) {
         sfile [i] = fopen (tfilename, "w+");
         if (! sfile [i])
diff --git a/src/cmd/ld/ld.c b/src/cmd/ld/ld.c
index 972624d..c3ee90d 100644
--- a/src/cmd/ld/ld.c
+++ b/src/cmd/ld/ld.c
@@ -1287,7 +1287,13 @@ void middle()
 void setupout ()
 {
 	tcreat (&outb, 0);
-	mktemp (tfname);
+	int fd = mkstemp (tfname);
+    if (fd == -1) {
+        error(2, "internal error: unable to create temporary file %s", tfname);
+    } else {
+        close(fd);
+    }
+        
 	tcreat (&toutb, 1);
 	tcreat (&doutb, 1);
 

From ad74c373181c59e776591ed62c2d406701fedd31 Mon Sep 17 00:00:00 2001
From: Matt Jenkins <matt@majenko.co.uk>
Date: Sat, 19 Apr 2014 11:39:55 +0100
Subject: [PATCH 3/4] Disabled verbose execution

---
 src/cmd/cron/putman.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/cmd/cron/putman.sh b/src/cmd/cron/putman.sh
index 84bf496..84f00fb 100755
--- a/src/cmd/cron/putman.sh
+++ b/src/cmd/cron/putman.sh
@@ -12,7 +12,7 @@ SECT=`expr $PAGE : '[a-z]*.\([0-9]\)'`
 MDIR="$DIR/cat$SECT"
 DEST="$MDIR/`basename $PAGE .$SECT`.0"
 
-set -x
+#set -x
 if [ ! -d $MDIR ]; then
 	rm -f $MDIR
 	mkdir -p $MDIR

From 22c2f77d84bfb95acd5507e5b7b1d18e07499732 Mon Sep 17 00:00:00 2001
From: Matt Jenkins <matt@majenko.co.uk>
Date: Sat, 19 Apr 2014 11:46:17 +0100
Subject: [PATCH 4/4] Added "create" flag to AR commands

---
 src/cmd/uucp/Makefile  | 2 +-
 src/libcurses/Makefile | 4 ++--
 src/libvmf/Makefile    | 4 ++--
 src/libwiznet/Makefile | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/cmd/uucp/Makefile b/src/cmd/uucp/Makefile
index 2ce6e11..3923691 100644
--- a/src/cmd/uucp/Makefile
+++ b/src/cmd/uucp/Makefile
@@ -126,7 +126,7 @@ uucico: cico.o libuucp.a
 	${ELF2AOUT} uucico.elf $@
 
 libuucp.a: $(LIBOBJ)
-	$(AR) r libuucp.a $(LIBOBJ)
+	$(AR) cru libuucp.a $(LIBOBJ)
 	$(RANLIB) libuucp.a
 
 
diff --git a/src/libcurses/Makefile b/src/libcurses/Makefile
index 1fec46a..d408673 100644
--- a/src/libcurses/Makefile
+++ b/src/libcurses/Makefile
@@ -35,12 +35,12 @@ all:    ../libcurses.a
 
 ../libcurses.a: ${OBJS}
 	@echo building normal ../libcurses.a
-	@$(AR) ru ../libcurses.a ${OBJS}
+	@$(AR) cru ../libcurses.a ${OBJS}
 	$(RANLIB) ../libcurses.a
 
 ../libcurses_p.a: ${OBJS}
 	@echo building profiled ../libcurses.a
-	@cd profiled; $(AR) ru ../../libcurses_p.a ${POBJS}
+	@cd profiled; $(AR) cru ../../libcurses_p.a ${POBJS}
 	$(RANLIB) ../libcurses_p.a
 
 install: all
diff --git a/src/libvmf/Makefile b/src/libvmf/Makefile
index 19aabd2..f02a15e 100644
--- a/src/libvmf/Makefile
+++ b/src/libvmf/Makefile
@@ -22,12 +22,12 @@ all:    	../libvmf.a $(MAN)
 
 ../libvmf.a: 	${OBJS}
 		@echo building normal ../libvmf.a
-		@$(AR) ru ../libvmf.a ${OBJS}
+		@$(AR) cru ../libvmf.a ${OBJS}
 		$(RANLIB) ../libvmf.a
 
 ../libvmf_p.a: 	${OBJS}
 		@echo building profiled ../libvmf.a
-		@cd profiled; $(AR) ru ../../libvmf_p.a ${POBJS}
+		@cd profiled; $(AR) cru ../../libvmf_p.a ${POBJS}
 		$(RANLIB) ../libvmf_p.a
 
 $(MAN):         $(MANSRC)
diff --git a/src/libwiznet/Makefile b/src/libwiznet/Makefile
index 0fadb8c..0bbcae4 100644
--- a/src/libwiznet/Makefile
+++ b/src/libwiznet/Makefile
@@ -8,7 +8,7 @@ OBJS    	= w5100.o socket.o ethernet.o client.o server.o udp.o
 all:    	../libwiznet.a
 
 ../libwiznet.a: ${OBJS}
-		@$(AR) ru $@ ${OBJS}
+		@$(AR) cru $@ ${OBJS}
 		$(RANLIB) $@
 
 install: 	all