D/ldc
1
0
Fork 0
mirror of https://github.com/xomboverlord/ldc.git synced 2026-10-14 08:07:01 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

Got rid of improper static array compile time index check.

Browse Source 
It had caused tango.core.Variant to fail to compile.
This commit is contained in:
Christian Kamm
2008-08-13 22:31:46 +02:00
parent 575ae2ea33
commit 53f8542719
1 changed files with 2 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
gen/arrays.cpp
+2 -17
View File
@@ -1035,23 +1035,8 @@ void DtoArrayBoundsCheck(Loc& loc, DValue* arr, DValue* index, bool isslice)
Type* arrty = arr->getType()->toBasetype();
assert((arrty->ty == Tsarray || arrty->ty == Tarray) && "Can only array bounds check for static or dynamic arrays");
// static arrays can get static checks for static indices
if(arr->getType()->ty == Tsarray)
{
TypeSArray* tsa = (TypeSArray*)arrty;
size_t tdim = tsa->dim->toInteger();
if(llvm::ConstantInt* cindex = llvm::dyn_cast<llvm::ConstantInt>(index->getRVal()))
if(cindex->uge(tdim + (isslice ? 1 : 0))) {
size_t cindexval = cindex->getValue().getZExtValue();
if(!isslice)
error(loc, "index %u is larger or equal array size %u", cindexval, tdim);
else
error(loc, "slice upper bound %u is larger than array size %u", cindexval, tdim);
return;
}
}
// static arrays could get static checks for static indices
// but shouldn't since it might be generic code that's never executed
// runtime check