D/ldc
1
0
Fork 0
mirror of https://github.com/xomboverlord/ldc.git synced 2026-02-07 07:23:13 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove initialization of padding of reals, ireals and creals.

Browse Source 
According to the spec and C ABIs, the contents of padding is undefined.
This was breaking dstress creal_01,02,03,07,08,09 and 20 on x86-64.

The code was apparently added to fix creal_13,14 and 15, which explicitly
compare padding and assert if it's different. I'd argue those tests are broken.
(Also, on x86-64 they *also* fail)

The tests this fixes, on the other hand, are basic arithmetic.
This commit is contained in:
Frits van Bommel
2009-02-27 19:41:25 +01:00
parent 2beff65988
commit 70b97b9d1e
1 changed files with 1 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
gen/llvmhelpers.cpp
View File

@@ -1378,30 +1378,7 @@ DValue* DtoInitializer(LLValue* target, Initializer* init)
{
Logger::println("expression initializer");
assert(ex->exp);
DValue* res = ex->exp->toElem(gIR);
assert(llvm::isa<llvm::PointerType>(target->getType()) && "init target must be ptr");
const LLType* targetty = target->getType()->getContainedType(0);
if(targetty == LLType::X86_FP80Ty)
{
Logger::println("setting fp80 padding to zero");
LLValue* castv = DtoBitCast(target, getPtrToType(LLType::Int16Ty));
LLValue* padding = DtoGEPi1(castv, 5);
DtoStore(llvm::Constant::getNullValue(LLType::Int16Ty), padding);
}
else if(targetty == DtoComplexType(Type::tcomplex80))
{
Logger::println("setting complex fp80 padding to zero");
LLValue* castv = DtoBitCast(target, getPtrToType(LLType::Int16Ty));
LLValue* padding = DtoGEPi1(castv, 5);
DtoStore(llvm::Constant::getNullValue(LLType::Int16Ty), padding);
padding = DtoGEPi1(castv, 11);
DtoStore(llvm::Constant::getNullValue(LLType::Int16Ty), padding);
}
return res;
return ex->exp->toElem(gIR);
}
else if (init->isVoidInitializer())
{