D/ldc
1
0
Fork 0
mirror of https://github.com/xomboverlord/ldc.git synced 2026-01-28 02:23:13 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Do not use internal linkage for a function nested in a small function that can be inlined from other modules

Browse Source
This commit is contained in:
Alexey Prokhin
2011-04-30 15:30:57 +04:00
parent 9e5b0e79e2
commit 73e498ace1
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
gen/tollvm.cpp
View File

@@ -310,10 +310,10 @@ LLGlobalValue::LinkageTypes DtoLinkage(Dsymbol* sym)
if (FuncDeclaration* fd = sym->isFuncDeclaration())
skipNestedCheck = (fd->naked != 0);
// Any symbol nested in a function can't be referenced directly from
// outside that function, so we can give such symbols internal linkage.
// This holds even if nested indirectly, such as member functions of
// aggregates nested in functions.
// Any symbol nested in a function that cannot be inlined can't be
// referenced directly from outside that function, so we can give
// such symbols internal linkage. This holds even if nested indirectly,
// such as member functions of aggregates nested in functions.
//
// Note: This must be checked after things like template member-ness or
// symbols nested in templates would get duplicated for each module,
@@ -323,11 +323,13 @@ LLGlobalValue::LinkageTypes DtoLinkage(Dsymbol* sym)
// ---
// if instances get emitted in multiple object files because they'd use
// different instances of 'i'.
if (!skipNestedCheck)
if (!skipNestedCheck) {
for (Dsymbol* parent = sym->parent; parent ; parent = parent->parent) {
if (parent->isFuncDeclaration())
FuncDeclaration *fd = parent->isFuncDeclaration();
if (fd && !fd->canInline(fd->needThis()))
return llvm::GlobalValue::InternalLinkage;
}
}
// default to external linkage
return llvm::GlobalValue::ExternalLinkage;