D/ldc
1
0
Fork 0
mirror of https://github.com/xomboverlord/ldc.git synced 2026-01-13 19:33:13 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Rename TD_Confirm to TD_TypeInfo.

Browse Source 
The old name probably was a reference to the fact that the
metadata node is used to _confirm_ that a metadata record
found by name really belongs to a given TypeInfo instance,
but I found it to be rather non-intuitive.
This commit is contained in:
David Nadlinger
2013-06-07 02:41:10 +02:00
parent 1c883c5071
commit af699bd76e
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gen/metadata.h
View File

@@ -32,7 +32,7 @@ typedef llvm::Value MDNodeField;
/// The fields in the metadata node for a TypeInfo instance.
/// (Its name will be TD_PREFIX ~ <Name of TypeInfo global>)
enum TypeDataFields {
TD_Confirm, /// The TypeInfo this node is for.
TD_TypeInfo, /// A reference toe the TypeInfo global this node is for.
TD_Type, /// A value of the LLVM type corresponding to this D type

4
gen/passes/GarbageCollect2Stack.cpp
View File

@@ -495,8 +495,8 @@ Type* Analysis::getTypeFor(Value* typeinfo) const {
if (node->getNumOperands() != TD_NumFields)
return NULL;
if (TD_Confirm >= 0 && (!node->getOperand(TD_Confirm) ||
node->getOperand(TD_Confirm)->stripPointerCasts() != ti_global))
if (TD_TypeInfo >= 0 && (!node->getOperand(TD_TypeInfo) ||
node->getOperand(TD_TypeInfo)->stripPointerCasts() != ti_global))
return NULL;
return node->getOperand(TD_Type)->getType();

4
gen/typinf.cpp
View File

@@ -328,8 +328,8 @@ void DtoResolveTypeInfo(TypeInfoDeclaration* tid)
if (!meta && tid->tinfo->toBasetype()->ty < Terror) {
// Construct the fields
MDNodeField* mdVals[TD_NumFields];
if (TD_Confirm >= 0)
mdVals[TD_Confirm] = llvm::cast<MDNodeField>(irg->value);
if (TD_TypeInfo >= 0)
mdVals[TD_TypeInfo] = llvm::cast<MDNodeField>(irg->value);
mdVals[TD_Type] = llvm::UndefValue::get(DtoType(tid->tinfo));
// Construct the metadata and insert it into the module.
llvm::NamedMDNode* node = gIR->module->getOrInsertNamedMetadata(metaname);