D/ldc
1
0
Fork 0
mirror of https://github.com/xomboverlord/ldc.git synced 2026-02-02 13:03:13 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Don't run inlining semantic3's on unit test builds.

Browse Source 
Fixes build of std.net.curl unit tests.
This commit is contained in:
David Nadlinger
2012-11-06 23:16:50 +01:00
parent 441419a60f
commit b7ecd71d75
1 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
driver/main.cpp
View File

@@ -1015,8 +1015,24 @@ int main(int argc, char** argv)
*/
if (!global.params.useArrayBounds && !global.params.useAssert)
#else
// This doesn't play nice with debug info at the moment
if (!global.params.symdebug && willInline())
// This doesn't play nice with debug info at the moment.
//
// Also, don't run the additional semantic3 passes when building unit tests.
// This is basically a huge hack around the fact that linking against a
// library is supposed to require the same compiler flags as when it was
// built, but -unittest is usually not thought to behave like this from a
// user perspective.
//
// Thus, if a library contained some functions in version(unittest), for
// example the tests in std.concurrency, and we ended up inline-scannin
// these functions while doing an -unittest build of a client application,
// we could end up referencing functions that we think are
// availableExternally, but have never been touched when the library was built.
//
// Alternatively, we could also amend the availableExternally detection
// logic (e.g. just codegen everything on -unittest builds), but the extra
// inlining is unlikely to be important for test builds anyway.
if (!global.params.symdebug && willInline() && !global.params.useUnitTests)
{
global.params.useAvailableExternally = true;
Logger::println("Running some extra semantic3's for inlining purposes");