D/ldc
1
0
Fork 0
mirror of https://github.com/xomboverlord/ldc.git synced 2026-01-29 02:53:14 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Avoid confusing naming convention.

Browse Source 
We generally do not really use underscore prefixes. But if
they are used in other codebases, they typically refer to
member variables.
This commit is contained in:
David Nadlinger
2013-05-18 17:24:25 +02:00
parent 7b435c2c87
commit f8f405000b
1 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
gen/declarations.cpp
View File

@@ -143,27 +143,26 @@ void VarDeclaration::codegen(Ir* p)
Logger::println("parent: %s (%s)", parent->toChars(), parent->kind());
// not sure why this is only needed for d2
bool _isconst = isConst() && init;
bool isLLConst = isConst() && init;
Logger::println("Creating global variable");
assert(!ir.initialized);
ir.initialized = gIR->dmodule;
std::string _name(mangle());
std::string llName(mangle());
LLType *_type = DtoConstInitializerType(type, init);
LLType *llType = DtoConstInitializerType(type, init);
// create the global variable
#if LDC_LLVM_VER >= 302
// FIXME: clang uses a command line option for the thread model
LLGlobalVariable* gvar = new LLGlobalVariable(*gIR->module, _type, _isconst,
DtoLinkage(this), NULL, _name, 0,
LLGlobalVariable* gvar = new LLGlobalVariable(*gIR->module, llType, isLLConst,
DtoLinkage(this), NULL, llName, 0,
isThreadlocal() ? LLGlobalVariable::GeneralDynamicTLSModel
: LLGlobalVariable::NotThreadLocal);
#else
LLGlobalVariable* gvar = new LLGlobalVariable(*gIR->module, _type, _isconst,
DtoLinkage(this), NULL, _name, 0, isThreadlocal());
LLGlobalVariable* gvar = new LLGlobalVariable(*gIR->module, llType, isLLConst,
DtoLinkage(this), NULL, llName, 0, isThreadlocal());
#endif
this->ir.irGlobal->value = gvar;