Updated test example cml. Also update to various comments

This commit is contained in:
Bahadir Balban
2009-11-03 16:04:43 +02:00
parent b7e575817d
commit 69ac6d67f0
2 changed files with 5 additions and 8 deletions

View File

@@ -88,7 +88,6 @@ CONFIG_CONT0_OPT_NAME="caps"
# #
CONFIG_CONT0_PAGER_LMA=0x40000 CONFIG_CONT0_PAGER_LMA=0x40000
CONFIG_CONT0_PAGER_VMA=0x10000000 CONFIG_CONT0_PAGER_VMA=0x10000000
CONFIG_CONT0_PAGER_SIZE=0x40000
# #

View File

@@ -99,9 +99,7 @@ struct capability *cap_list_find_by_rtype(struct cap_list *cap_list,
* to free it to. * to free it to.
* *
* In conclusion freeing of pool-type capabilities need to be done * In conclusion freeing of pool-type capabilities need to be done
* in order of privacy. -> It may get confusing as a space, thread * in order of privacy.
* group id or paged-thread group is not necessarily in a different
* privacy ring.
*/ */
struct capability *capability_find_by_rtype(struct ktcb *task, struct capability *capability_find_by_rtype(struct ktcb *task,
unsigned int rtype) unsigned int rtype)
@@ -453,7 +451,7 @@ struct capability *cap_match_thread(struct capability *cap,
if (action_flags == THREAD_CREATE) { if (action_flags == THREAD_CREATE) {
/* /*
* FIXME: Add cid to task_ids arg. * TODO: Add cid to task_ids arg.
* *
* Its a thread create and we have no knowledge of * Its a thread create and we have no knowledge of
* thread id, space id, or any other id. * thread id, space id, or any other id.
@@ -618,8 +616,8 @@ int cap_map_check(struct ktcb *target, unsigned long phys, unsigned long virt,
/* /*
* Limitation: We currently only check from sender's * Limitation: We currently only check from sender's
* perspective. Sender always targets a real thread. * perspective. This is because sender always targets a
* Does sender have the right to do this ipc? * real thread. Does sender have the right to do this ipc?
*/ */
int cap_ipc_check(l4id_t to, l4id_t from, int cap_ipc_check(l4id_t to, l4id_t from,
unsigned int flags, unsigned int ipc_type) unsigned int flags, unsigned int ipc_type)
@@ -716,7 +714,7 @@ int cap_thread_check(struct ktcb *task,
{ {
return 0; return 0;
} }
#endif #endif /* End of !CONFIG_CAPABILITIES */
/* /*
* FIXME: * FIXME: