sambuc/codezero
1
0
Fork 0
mirror of https://github.com/drasko/codezero.git synced 2026-01-13 11:23:16 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fixed few more anomalies with threaded irqs.

Browse Source 
There is a bug that causes the sleeping irq
thread to never wake up. Investigating.
This commit is contained in:
Bahadir Balban
2009-12-13 20:35:04 +02:00
parent 0c4bd69357
commit d85ccdb3fe
10 changed files with 66 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/api/irq.c
View File

@@ -12,6 +12,7 @@
#include <l4/generic/tcb.h>
#include INC_GLUE(message.h)
#include <l4/lib/wait.h>
#include INC_SUBARCH(irq.h)
/*
* Default function that handles userspace
@@ -57,12 +58,13 @@ int irq_thread_notify(struct irq_desc *desc)
utcb = (struct utcb *)desc->task->utcb_address;
/* Atomic increment (See above comments) with no wraparound */
if (utcb->notify[desc->task_notify_slot] != TASK_NOTIFY_MAX)
if (utcb->notify[desc->task_notify_slot] != TASK_NOTIFY_MAXVALUE)
utcb->notify[desc->task_notify_slot]++;
/* Async wake up any waiter irq threads */
wake_up(&desc->task->wqh_notify, WAKEUP_ASYNC);
wake_up(&desc->wqh_irq, WAKEUP_ASYNC);
BUG_ON(!irqs_enabled());
return 0;
}
@@ -111,10 +113,13 @@ int irq_wait(l4id_t irq_index)
/* Wait until the irq changes slot value */
WAIT_EVENT(&desc->wqh_irq,
!utcb->notify[desc->task_notify_slot],
utcb->notify[desc->task_notify_slot] != 0,
ret);
return ret;
printk("Didn't sleep. utcb->notify[%d]=%d\n", desc->task_notify_slot, utcb->notify[desc->task_notify_slot]);
if (ret < 0)
return ret;
else
return l4_atomic_dest_readb(&utcb->notify[desc->task_notify_slot]);
}