sambuc/retrobsd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Simplify spi_setup() function parameters.

Browse Source
This commit is contained in:
Serge Vakulenko
2015-09-30 13:03:12 -07:00
parent e8e186905a
commit 3e439df5a2
6 changed files with 34 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
sys/include/spi.h
View File

@@ -49,7 +49,7 @@ struct spiio {
unsigned int mode;
};
extern int spi_setup(struct spiio *io, int channel, unsigned int *tris, unsigned int pin);
extern int spi_setup(struct spiio *io, int channel, int cs);
extern void spi_set_cspin(struct spiio *io, unsigned int *tris, unsigned int pin);
extern void spi_select(struct spiio *io);
extern void spi_deselect(struct spiio *io);

16
sys/pic32/mrams.c
View File

@@ -243,14 +243,6 @@ int mrams_write(unsigned int offset, char *data, unsigned bcount)
return 1;
}
static unsigned *gpio_base(int cs)
{
int port = (cs >> 4) - 1;
struct gpioreg *base = port + (struct gpioreg*) &TRISA;
return (unsigned int*) base;
}
/*
* Initialize hardware.
*/
@@ -258,7 +250,7 @@ static int mrams_init(int spi_port, int cs0, int cs1, int cs2, int cs3)
{
struct spiio *io = &mrams_io[0];
if (spi_setup(io, spi_port, gpio_base(cs0), cs0 & 15) != 0) {
if (spi_setup(io, spi_port, cs0) != 0) {
printf("mr0: cannot open SPI%u port\n", spi_port);
return 0;
}
@@ -269,7 +261,7 @@ static int mrams_init(int spi_port, int cs0, int cs1, int cs2, int cs3)
spi_deselect(io);
#if MRAMS_CHIPS >= 1
spi_setup(io+1, spi_port, gpio_base(cs1), cs1 & 15);
spi_setup(io+1, spi_port, cs1);
spi_brg(io+1, MRAMS_MHZ * 1000);
spi_set(io+1, PIC32_SPICON_CKE);
@@ -278,7 +270,7 @@ static int mrams_init(int spi_port, int cs0, int cs1, int cs2, int cs3)
spi_deselect(io+1);
#endif
#if MRAMS_CHIPS >= 2
spi_setup(io+2, spi_port, gpio_base(cs2), cs2 & 15);
spi_setup(io+2, spi_port, cs2);
spi_brg(io+2, MRAMS_MHZ * 1000);
spi_set(io+2, PIC32_SPICON_CKE);
@@ -287,7 +279,7 @@ static int mrams_init(int spi_port, int cs0, int cs1, int cs2, int cs3)
spi_deselect(io+2);
#endif
#if MRAMS_CHIPS >= 3
spi_setup(io+3, spi_port, gpio_base(cs3), cs3 & 15);
spi_setup(io+3, spi_port, cs3);
spi_brg(io+3, MRAMS_MHZ * 1000);
spi_set(io+3, PIC32_SPICON_CKE);

6
sys/pic32/sd.c
View File

@@ -877,11 +877,7 @@ sd_probe(config)
printf("sd%u: port SPI%d, pin cs=R%c%d\n", unit,
config->dev_ctlr, gpio_portname(cs), gpio_pinno(cs));
int port = (cs >> 4) - 1;
int pin = cs & 15;
struct gpioreg *base = port + (struct gpioreg*) &TRISA;
if (spi_setup(io, config->dev_ctlr, (unsigned int*) base, pin) != 0) {
if (spi_setup(io, config->dev_ctlr, cs) != 0) {
printf("sd%u: cannot open SPI%u port\n", unit, config->dev_ctlr);
return 0;
}

2
sys/pic32/spi.c
View File

@@ -317,7 +317,7 @@ spiprobe(config)
gpio_portname(sdo), gpio_pinno(sdo),
gpio_portname(sck), gpio_pinno(sck));
if (spi_setup(io, channel+1, 0, 0) != 0) {
if (spi_setup(io, channel+1, 0) != 0) {
printf("spi%u: setup failed\n", channel+1);
return 0;
}

12
sys/pic32/spi_bus.c
View File

@@ -28,11 +28,21 @@ static struct spireg *const spi_base[NSPI] = {
// Returns an integer for the number of the device (ala fd).
// Returns -1 if no devices are available.
//
int spi_setup(struct spiio *io, int channel, unsigned int *tris, unsigned int pin)
int spi_setup(struct spiio *io, int channel, int cs)
{
unsigned *tris = 0;
int pin = 0;
if (channel <= 0 || channel > NSPI)
return ENXIO;
if (cs != 0) {
/* Compute the port address and pin index of the chip select signal. */
int port = (cs >> 4) - 1;
tris = (unsigned*) (port + (struct gpioreg*) &TRISA);
pin = cs & 15;
}
// Set up the device
io->bus = spi_base[channel-1];
io->cs_tris = tris;

40
sys/pic32/spirams.c
View File

@@ -315,14 +315,6 @@ int spirams_write (unsigned int offset, char *data, unsigned bcount)
return 1;
}
static unsigned *gpio_base(int cs)
{
int port = (cs >> 4) - 1;
struct gpioreg *base = port + (struct gpioreg*) &TRISA;
return (unsigned int*) base;
}
/*
* Initialize hardware.
*/
@@ -330,7 +322,7 @@ static int spirams_init(int spi_port, char cs[])
{
struct spiio *io = &spirams_io[0];
if (spi_setup(io, spi_port, gpio_base(cs[0]), cs[0] & 15) != 0) {
if (spi_setup(io, spi_port, cs[0]) != 0) {
printf("sr0: cannot open SPI%u port\n", spi_port);
return 0;
}
@@ -338,91 +330,91 @@ static int spirams_init(int spi_port, char cs[])
spi_set(io, PIC32_SPICON_CKE);
#if SPIRAMS_CHIPS >= 1
spi_setup(io+1, spi_port, gpio_base(cs[1]), cs[1] & 15);
spi_setup(io+1, spi_port, cs[1]);
spi_brg(io+1, SPIRAMS_MHZ * 1000);
spi_set(io+1, PIC32_SPICON_CKE);
#endif
#if SPIRAMS_CHIPS >= 2
spi_setup(io+2, spi_port, gpio_base(cs[2]), cs[2] & 15);
spi_setup(io+2, spi_port, cs[2]);
spi_brg(io+2, SPIRAMS_MHZ * 1000);
spi_set(io+2, PIC32_SPICON_CKE);
#endif
#if SPIRAMS_CHIPS >= 3
spi_setup(io+3, spi_port, gpio_base(cs[3]), cs[3] & 15);
spi_setup(io+3, spi_port, cs[3]);
spi_brg(io+3, SPIRAMS_MHZ * 1000);
spi_set(io+3, PIC32_SPICON_CKE);
#endif
#if SPIRAMS_CHIPS >= 4
spi_setup(io+4, spi_port, gpio_base(cs[4]), cs[4] & 15);
spi_setup(io+4, spi_port, cs[4]);
spi_brg(io+4, SPIRAMS_MHZ * 1000);
spi_set(io+4, PIC32_SPICON_CKE);
#endif
#if SPIRAMS_CHIPS >= 5
spi_setup(io+5, spi_port, gpio_base(cs[5]), cs[5] & 15);
spi_setup(io+5, spi_port, cs[5]);
spi_brg(io+5, SPIRAMS_MHZ * 1000);
spi_set(io+5, PIC32_SPICON_CKE);
#endif
#if SPIRAMS_CHIPS >= 6
spi_setup(io+6, spi_port, gpio_base(cs[6]), cs[6] & 15);
spi_setup(io+6, spi_port, cs[6]);
spi_brg(io+6, SPIRAMS_MHZ * 1000);
spi_set(io+6, PIC32_SPICON_CKE);
#endif
#if SPIRAMS_CHIPS >= 7
spi_setup(io+7, spi_port, gpio_base(cs[7]), cs[7] & 15);
spi_setup(io+7, spi_port, cs[7]);
spi_brg(io+7, SPIRAMS_MHZ * 1000);
spi_set(io+7, PIC32_SPICON_CKE);
#endif
#if SPIRAMS_CHIPS >= 8
spi_setup(io+8, spi_port, gpio_base(cs[8]), cs[8] & 15);
spi_setup(io+8, spi_port, cs[8]);
spi_brg(io+8, SPIRAMS_MHZ * 1000);
spi_set(io+8, PIC32_SPICON_CKE);
#endif
#if SPIRAMS_CHIPS >= 9
spi_setup(io+9, spi_port, gpio_base(cs[9]), cs[9] & 15);
spi_setup(io+9, spi_port, cs[9]);
spi_brg(io+9, SPIRAMS_MHZ * 1000);
spi_set(io+9, PIC32_SPICON_CKE);
#endif
#if SPIRAMS_CHIPS >= 10
spi_setup(io+10, spi_port, gpio_base(cs[10]), cs[10] & 15);
spi_setup(io+10, spi_port, cs[10]);
spi_brg(io+10, SPIRAMS_MHZ * 1000);
spi_set(io+10, PIC32_SPICON_CKE);
#endif
#if SPIRAMS_CHIPS >= 11
spi_setup(io+11, spi_port, gpio_base(cs[11]), cs[11] & 15);
spi_setup(io+11, spi_port, cs[11]);
spi_brg(io+11, SPIRAMS_MHZ * 1000);
spi_set(io+11, PIC32_SPICON_CKE);
#endif
#if SPIRAMS_CHIPS >= 12
spi_setup(io+12, spi_port, gpio_base(cs[12]), cs[12] & 15);
spi_setup(io+12, spi_port, cs[12]);
spi_brg(io+12, SPIRAMS_MHZ * 1000);
spi_set(io+12, PIC32_SPICON_CKE);
#endif
#if SPIRAMS_CHIPS >= 13
spi_setup(io+13, spi_port, gpio_base(cs[13]), cs[13] & 15);
spi_setup(io+13, spi_port, cs[13]);
spi_brg(io+13, SPIRAMS_MHZ * 1000);
spi_set(io+13, PIC32_SPICON_CKE);
#endif
#if SPIRAMS_CHIPS >= 14
spi_setup(io+14, spi_port, gpio_base(cs[14]), cs[14] & 15);
spi_setup(io+14, spi_port, cs[14]);
spi_brg(io+14, SPIRAMS_MHZ * 1000);
spi_set(io+14, PIC32_SPICON_CKE);
#endif
#if SPIRAMS_CHIPS >= 15
spi_setup(io+15, spi_port, gpio_base(cs[15]), cs[15] & 15);
spi_setup(io+15, spi_port, cs[15]);
spi_brg(io+15, SPIRAMS_MHZ * 1000);
spi_set(io+15, PIC32_SPICON_CKE);